]> granicus.if.org Git - clang/commit
[clang-format] Ensure wrapped ObjC selectors with 1 arg obey IndentWrappedFunctionNames
authorBen Hamilton <benhamilton@google.com>
Fri, 30 Mar 2018 15:38:45 +0000 (15:38 +0000)
committerBen Hamilton <benhamilton@google.com>
Fri, 30 Mar 2018 15:38:45 +0000 (15:38 +0000)
commit6efe17611a988cf2f4a78ab34b04f24ea7fc7dd9
tree4d436b030a252b0aa26a9ae65d86bc1799273e76
parent27e25eb7f8a0d7153d31956f3c612179017fb7d8
[clang-format] Ensure wrapped ObjC selectors with 1 arg obey IndentWrappedFunctionNames

Summary:
In D43121, @Typz introduced logic to avoid indenting 2-or-more
argument ObjC selectors too far to the right if the first component
of the selector was longer than the others.

This had a small side effect of causing wrapped ObjC selectors with
exactly 1 argument to not obey IndentWrappedFunctionNames:

```
- (aaaaaaaaaa)
aaaaaaaaaa;
```

This diff fixes the issue by ensuring we align wrapped 1-argument
ObjC selectors correctly:

```
- (aaaaaaaaaa)
    aaaaaaaaaa;
```

Test Plan: New tests added. Test failed before change, passed
  after change. Ran tests with:
  % make -j12 FormatTests && ./tools/clang/unittests/Format/FormatTests

Reviewers: djasper, klimek, Typz, jolesiak

Reviewed By: djasper, jolesiak

Subscribers: cfe-commits, Typz

Differential Revision: https://reviews.llvm.org/D44994

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@328871 91177308-0d34-0410-b5e6-96231b3b80d8
lib/Format/ContinuationIndenter.cpp
unittests/Format/FormatTestObjC.cpp