]> granicus.if.org Git - llvm/commit
[WebAssembly] Merge used feature sets, update atomics linkage policy
authorThomas Lively <tlively@google.com>
Fri, 29 Mar 2019 00:14:01 +0000 (00:14 +0000)
committerThomas Lively <tlively@google.com>
Fri, 29 Mar 2019 00:14:01 +0000 (00:14 +0000)
commit6d7e6d99405c4444a70876c0c57aa6e49fabf03a
treed97cf021c345bb6bb98da0052d5591b8edf27503
parent35945918f0209881fa9ef4e35a3a67ec5ce91052
[WebAssembly] Merge used feature sets, update atomics linkage policy

Summary:
It does not currently make sense to use WebAssembly features in some functions
but not others, so this CL adds an IR pass that takes the union of all used
feature sets and applies it to each function in the module. This allows us to
prevent atomics from being lowered away if some function has opted in to using
them. When atomics is not enabled anywhere, we detect whether there exists any
atomic operations or thread local storage that would be stripped and disallow
linking with objects that contain atomics if and only if atomics or tls are
stripped. When atomics is enabled, mark it as used but do not require it of
other objects in the link. These changes allow libraries that do not use atomics
to be built once and linked into both single-threaded and multithreaded
binaries.

Reviewers: aheejin, sbc100, dschuff

Subscribers: jgravelle-google, hiraditya, sunfish, jfb, llvm-commits

Tags: #llvm

Differential Revision: https://reviews.llvm.org/D59625

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@357226 91177308-0d34-0410-b5e6-96231b3b80d8
20 files changed:
lib/Target/WebAssembly/MCTargetDesc/WebAssemblyMCTargetDesc.h
lib/Target/WebAssembly/WebAssemblyAsmPrinter.cpp
lib/Target/WebAssembly/WebAssemblyAsmPrinter.h
lib/Target/WebAssembly/WebAssemblySubtarget.cpp
lib/Target/WebAssembly/WebAssemblySubtarget.h
lib/Target/WebAssembly/WebAssemblyTargetMachine.cpp
lib/Target/WebAssembly/WebAssemblyTargetMachine.h
test/CodeGen/WebAssembly/target-features-tls.ll [new file with mode: 0644]
test/CodeGen/WebAssembly/target-features.ll
test/MC/WebAssembly/array-fill.ll
test/MC/WebAssembly/assembler-binary.ll
test/MC/WebAssembly/bss.ll
test/MC/WebAssembly/comdat.ll
test/MC/WebAssembly/debug-info.ll
test/MC/WebAssembly/explicit-sections.ll
test/MC/WebAssembly/global-ctor-dtor.ll
test/MC/WebAssembly/visibility.ll
test/MC/WebAssembly/weak-alias.ll
test/MC/WebAssembly/weak.ll
utils/TableGen/SubtargetEmitter.cpp