]> granicus.if.org Git - postgresql/commit
Add an Assert that enum_cmp_internal() gets passed an FmgrInfo pointer.
authorTom Lane <tgl@sss.pgh.pa.us>
Fri, 24 Feb 2017 03:08:10 +0000 (22:08 -0500)
committerTom Lane <tgl@sss.pgh.pa.us>
Fri, 24 Feb 2017 03:08:10 +0000 (22:08 -0500)
commit6d493e1a013514a6f0abb5d30d08219c1831cfec
treeaa5216c7cc724a5b11205ee49be6296d8d7efd53
parentc29aff959dc64f7321062e7f33d8c6ec23db53d3
Add an Assert that enum_cmp_internal() gets passed an FmgrInfo pointer.

If someone were to try to call one of the enum comparison functions
using DirectFunctionCallN, it would very likely seem to work, because
only in unusual cases does enum_cmp_internal() need to access the
typcache.  But once such a case occurred, code like that would crash
with a null pointer dereference.  To make an oversight of that sort
less likely to escape detection, add a non-bypassable Assert that
fcinfo->flinfo isn't NULL.

Discussion: https://postgr.es/m/25226.1487900067@sss.pgh.pa.us
src/backend/utils/adt/enum.c