]> granicus.if.org Git - postgresql/commit
Fix assertion failure when updating full_page_writes for checkpointer.
authorAmit Kapila <akapila@postgresql.org>
Fri, 28 Sep 2018 06:54:09 +0000 (12:24 +0530)
committerAmit Kapila <akapila@postgresql.org>
Fri, 28 Sep 2018 11:10:43 +0000 (16:40 +0530)
commit6c8671bc395c9be44571e424c458b94ec20975d3
treea348f3c2e362ffed77dd9230c72355c728808800
parent88926fd481b7d1c928947230e154235d9d9720f4
Fix assertion failure when updating full_page_writes for checkpointer.

When the checkpointer receives a SIGHUP signal to update its configuration,
it may need to update the shared memory for full_page_writes and need to
write a WAL record for it.  Now, it is quite possible that the XLOG
machinery has not been initialized by that time and it will lead to
assertion failure while doing that.  Fix is to allow the initialization of
the XLOG machinery outside critical section.

This bug has been introduced by the commit 2c03216d83 which added the XLOG
machinery initialization in RecoveryInProgress code path.

Reported-by: Dilip Kumar
Author: Dilip Kumar
Reviewed-by: Michael Paquier and Amit Kapila
Backpatch-through: 9.5
Discussion: https://postgr.es/m/CAFiTN-u4BA8KXcQUWDPNgaKAjDXC=C2whnzBM8TAcv=stckYUw@mail.gmail.com
src/backend/access/transam/xlog.c