]> granicus.if.org Git - postgresql/commit
Fix file descriptor leak after failure of a \setshell command in pgbench.
authorTom Lane <tgl@sss.pgh.pa.us>
Tue, 16 Dec 2014 18:31:42 +0000 (13:31 -0500)
committerTom Lane <tgl@sss.pgh.pa.us>
Tue, 16 Dec 2014 18:31:57 +0000 (13:31 -0500)
commit6c75384eed8770b11f01378b37dc4bd07a5710f1
treeff26063953fd46e3542ba052be579a2e7a4e55a5
parentce864d3276a29fc39155348e6e5ca282d1e51d2d
Fix file descriptor leak after failure of a \setshell command in pgbench.

If the called command fails to return data, runShellCommand forgot to
pclose() the pipe before returning.  This is fairly harmless in the current
code, because pgbench would then abandon further processing of that client
thread; so no more than nclients descriptors could be leaked this way.  But
it's not hard to imagine future improvements whereby that wouldn't be true.
In any case, it's sloppy coding, so patch all branches.  Found by Coverity.
contrib/pgbench/pgbench.c