]> granicus.if.org Git - postgresql/commit
Fix indexable-row-comparison logic to account for covering indexes.
authorTom Lane <tgl@sss.pgh.pa.us>
Mon, 11 Feb 2019 03:51:32 +0000 (22:51 -0500)
committerTom Lane <tgl@sss.pgh.pa.us>
Mon, 11 Feb 2019 03:51:32 +0000 (22:51 -0500)
commit6bdc3005b54fc9c6ef27cd4e64edd548315f57ba
tree139cf0fbb94554bee8fda56cbc10c5a9067738f9
parent72d71e03563b6c295b257040e324793a30162042
Fix indexable-row-comparison logic to account for covering indexes.

indxpath.c needs a good deal more attention for covering indexes than
it's gotten.  But so far as I can tell, the only really awful breakage
is in expand_indexqual_rowcompare (nee adjust_rowcompare_for_index),
which was only half fixed in c266ed31a.  The other problems aren't
bad enough to take the risk of a just-before-wrap fix.

The problem here is that if the leading column of a row comparison
matches an index (allowing this code to be reached), and some later
column doesn't match the index, it'll nonetheless believe that that
column matches the first included index column.  Typically that'll
lead to an error like "operator M is not a member of opfamily N" as
a result of fetching a garbage opfamily OID.  But with enough bad
luck, maybe a broken plan would be generated.

Discussion: https://postgr.es/m/25526.1549847928@sss.pgh.pa.us
src/backend/optimizer/path/indxpath.c
src/test/regress/expected/index_including.out
src/test/regress/sql/index_including.sql