]> granicus.if.org Git - postgresql/commit
Avoid unnecessary use of strncpy in a couple of places in ecpg.
authorTom Lane <tgl@sss.pgh.pa.us>
Sat, 16 Jun 2018 18:58:11 +0000 (14:58 -0400)
committerTom Lane <tgl@sss.pgh.pa.us>
Sat, 16 Jun 2018 18:58:11 +0000 (14:58 -0400)
commit6b74f5eaadc4489e08a23686f99f096ad0e08936
treeb312caa43cb101f10fa2a4e4bb2950c9cbc8f142
parent5d923eb29bb643e311680bab329363d8a9a9768a
Avoid unnecessary use of strncpy in a couple of places in ecpg.

Use of strncpy with a length limit based on the source, rather than
the destination, is non-idiomatic and draws warnings from gcc 8.
Replace with memcpy, which does exactly the same thing in these cases,
but with less chance for confusion.

Backpatch to all supported branches.

Discussion: https://postgr.es/m/21789.1529170195@sss.pgh.pa.us
src/interfaces/ecpg/ecpglib/descriptor.c
src/interfaces/ecpg/pgtypeslib/common.c