]> granicus.if.org Git - python/commit
projects / python / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: 70c5f2a) | patch
bpo-36813: Fix QueueListener to call task_done() upon termination. (GH-13113)
authorBar Harel <bzvi7919@gmail.com>
Sat, 1 Jun 2019 09:19:09 +0000 (12:19 +0300)
committerMiss Islington (bot) <31488909+miss-islington@users.noreply.github.com>
Sat, 1 Jun 2019 09:19:09 +0000 (02:19 -0700)
commit6b282e18877ec84e927b381b4ce187eaf4ba3dd7
tree67b8d2c67bc175ee2fcbf2d5164e4dcba6291c50tree | snapshot
parent70c5f2ae6e6a07d44a8d3f3202ea01bf697e05dbcommit | diff
bpo-36813: Fix QueueListener to call task_done() upon termination. (GH-13113)

Fixed QueueListener in order to avoid random deadlocks.
Unable to add regression tests atm due to time constraints, will add it in a bit.
Regarding implementation, although it's nested, it does not cause performance issues whatsoever, and does not call task_done() in case of an exception (which is the right thing to do IMHO).

https://bugs.python.org/issue36813
Lib/logging/handlers.py diff | blob | history
Lib/test/test_logging.py diff | blob | history
Misc/NEWS.d/next/Library/2019-05-06-18-28-38.bpo-36813.NXD0KZ.rst [new file with mode: 0644] blob
Unnamed repository; edit this file 'description' to name the repository.