]> granicus.if.org Git - postgresql/commit
Fix RelationIdGetRelation calls that weren't bothering with error checks.
authorTom Lane <tgl@sss.pgh.pa.us>
Sun, 8 Sep 2019 21:00:29 +0000 (17:00 -0400)
committerTom Lane <tgl@sss.pgh.pa.us>
Sun, 8 Sep 2019 21:00:53 +0000 (17:00 -0400)
commit69f883fef14a3fc5849126799278abcc43f40f56
tree45b200f74ee4f327d6c27aa75ad5887a0b814dcd
parentd807200b4a73a100cb8f41ee2f3ff1e2507647b8
Fix RelationIdGetRelation calls that weren't bothering with error checks.

Some of these are quite old, but that doesn't make them not bugs.
We'd rather report a failure via elog than SIGSEGV.

While at it, uniformly spell the error check as !RelationIsValid(rel)
rather than a bare rel == NULL test.  The machine code is the same
but it seems better to be consistent.

Coverity complained about this today, not sure why, because the
mistake is in fact old.
src/backend/access/heap/heapam.c
src/backend/replication/logical/reorderbuffer.c