]> granicus.if.org Git - postgresql/commit
projects / postgresql / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: cf2b5f9) | patch
Fix misuse of TextDatumGetCString().
authorTom Lane <tgl@sss.pgh.pa.us>
Thu, 2 Jul 2015 21:02:08 +0000 (17:02 -0400)
committerTom Lane <tgl@sss.pgh.pa.us>
Thu, 2 Jul 2015 21:02:14 +0000 (17:02 -0400)
commit69e9f9639d5c569a71c82f99550e7bf2912664f1
treed3d6f68e85358fdd28cb5919fa280940ee450a66tree | snapshot
parentcf2b5f9b33fda1cbeb8efdfd3989b5e88af74167commit | diff
Fix misuse of TextDatumGetCString().

"TextDatumGetCString(PG_GETARG_TEXT_P(x))" is formally wrong: a text*
is not a Datum.  Although this coding will accidentally fail to fail on
all known platforms, it risks leaking memory if a detoast step is needed,
unlike "TextDatumGetCString(PG_GETARG_DATUM(x))" which is what's used
elsewhere.  Make pg_get_object_address() fall in line with other uses.

Noted while reviewing two-arg current_setting() patch.
src/backend/catalog/objectaddress.c diff | blob | history
Unnamed repository; edit this file 'description' to name the repository.