]> granicus.if.org Git - postgresql/commit
Add CheckTableNotInUse calls in DROP TABLE and DROP INDEX.
authorTom Lane <tgl@sss.pgh.pa.us>
Tue, 15 Feb 2011 20:50:17 +0000 (15:50 -0500)
committerTom Lane <tgl@sss.pgh.pa.us>
Tue, 15 Feb 2011 20:50:17 +0000 (15:50 -0500)
commit69bef7ff79eb33e8a355e79e7fbb5338d1557775
tree87be2a9d3e53cf0662f8e443e2b27eee1b6c954f
parent13a9a7b55b4ced1ac017a3ca5a10f600d242a27a
Add CheckTableNotInUse calls in DROP TABLE and DROP INDEX.

Recent releases had a check on rel->rd_refcnt in heap_drop_with_catalog,
but failed to cover the possibility of pending trigger events at DROP time.
(Before 8.4 we didn't even check the refcnt.)  When the trigger events were
eventually fired, you'd get "could not open relation with OID nnn" errors,
as in recent report from strk.  Better to throw a suitable error when the
DROP is attempted.

Also add a similar check in DROP INDEX.

Back-patch to all supported branches.
src/backend/catalog/heap.c
src/backend/catalog/index.c