]> granicus.if.org Git - postgresql/commit
Fix misplacement of submake-generated-headers prerequisites.
authorTom Lane <tgl@sss.pgh.pa.us>
Sat, 1 Oct 2016 17:35:13 +0000 (13:35 -0400)
committerTom Lane <tgl@sss.pgh.pa.us>
Sat, 1 Oct 2016 17:35:20 +0000 (13:35 -0400)
commit68fb75e103e78478ef45a71e1a25055751e789f2
treee7b5d34067b00bc4bfa2f8f3c98607cd3d92377a
parent53fbeed40702e49c02a85a31f52a1683abe57a4e
Fix misplacement of submake-generated-headers prerequisites.

The sequence "configure; cd src/pl/plpython; make -j" failed due to
trying to compile plpython's .o files before the generated headers
finished building.  (This is an important real-world case, since it's
the typical second step when building both plpython2 and plpython3.)
This happens because the submake-generated-headers target is not
placed in a way to make it a prerequisite to compiling the .o files.
Fix that.

Checking other uses of submake-generated-headers, I noted that the one
attached to pg_regress was similarly misplaced; but it's actually not
needed at all for pg_regress.o, rather regress.o, so move it to be a
prerequisite of that.

Back-patch to 9.6 where submake-generated-headers was introduced
(by commit 548af97fc).  It's not immediately clear to me why the
previous coding didn't have the same issue; but since we've not
had field reports of plpython make failing, leave it alone in the
older branches.

Pavel Raiskup and Tom Lane

Discussion: <1925924.izSMJEZO3x@unused-4-107.brq.redhat.com>
src/pl/plpython/Makefile
src/test/regress/GNUmakefile