]> granicus.if.org Git - llvm/commit
projects / llvm / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: 3058248) | patch
[ARM] t2_so_imm_neg had a subtle bug in the conversion, and could trigger UB by negat...
authorArtyom Skrobov <Artyom.Skrobov@arm.com>
Wed, 22 Mar 2017 15:09:30 +0000 (15:09 +0000)
committerArtyom Skrobov <Artyom.Skrobov@arm.com>
Wed, 22 Mar 2017 15:09:30 +0000 (15:09 +0000)
commit677bddb49c66987005264c262e36c40438dbf82a
treefa69d5fa76a0ff5637d52b13cc6135b2b8f22a98tree | snapshot
parent30582488b0d9d8b8e0e9efc0c1e27f3f76680689commit | diff
[ARM] t2_so_imm_neg had a subtle bug in the conversion, and could trigger UB by negating (int)-2147483648. By pure luck, none of the pre-existing tests triggered this; so I'm adding one.

Summary: Thanks to Vitaly Buka for helping catch this.

Reviewers: rengolin, jmolloy, efriedma, vitalybuka

Subscribers: llvm-commits, aemerson

Differential Revision: https://reviews.llvm.org/D31242

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@298512 91177308-0d34-0410-b5e6-96231b3b80d8
lib/Target/ARM/ARMInstrThumb2.td diff | blob | history
test/CodeGen/Thumb/ispositive.ll diff | blob | history
Unnamed repository; edit this file 'description' to name the repository.