]> granicus.if.org Git - clang/commit
Provide the correct mangling and linkage for certain unnamed nested classes.
authorDavid Blaikie <dblaikie@gmail.com>
Wed, 14 Nov 2012 01:52:05 +0000 (01:52 +0000)
committerDavid Blaikie <dblaikie@gmail.com>
Wed, 14 Nov 2012 01:52:05 +0000 (01:52 +0000)
commit66cff7257698d5528632917d38f9a3037bb1506d
treefefc3721c4dc56667bdecdbd4dd076dc4c2f5ceb
parent0aabf93bc8e0fe5da316a66470aa8584017d0f6e
Provide the correct mangling and linkage for certain unnamed nested classes.

This corrects the mangling and linkage of classes (& their member functions) in
cases like this:

  struct foo {
    struct {
      void func() { ... }
    } x;
  };

we were accidentally giving this nested unnamed struct 'no' linkage where it
should've had the linkage of the outer class. The mangling was incorrecty too,
mangling as TU-wide unnamed type mangling of $_X rather than class-scoped
mangling of UtX_.

This also fixes -Wunused-member-function which would incorrectly diagnose
'func' as unused due to it having no linkage & thus appearing to be TU-local
when in fact it might be correctly used in another TU.

Similar mangling should be applied to function local classes in similar cases
but I've deferred that for a subsequent patch.

Review/discussion by Richard Smith, John McCall, & especially Eli Friedman.

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@167906 91177308-0d34-0410-b5e6-96231b3b80d8
include/clang/AST/ASTContext.h
include/clang/Sema/DeclSpec.h
lib/AST/ASTContext.cpp
lib/AST/Decl.cpp
lib/AST/ItaniumMangle.cpp
lib/Sema/SemaDecl.cpp
test/CodeGenCXX/mangle.cpp
test/CodeGenCXX/template-anonymous-types.cpp
test/SemaCXX/warn-unused-filescoped.cpp