]> granicus.if.org Git - llvm/commit
[ORC] fix use-after-free detected by -Wreturn-stack-address
authorMatthias Gehre <M.Gehre@gmx.de>
Mon, 19 Aug 2019 21:59:44 +0000 (21:59 +0000)
committerMatthias Gehre <M.Gehre@gmx.de>
Mon, 19 Aug 2019 21:59:44 +0000 (21:59 +0000)
commit665ea96bb51b06b05d18eddd5fd938f5a536e28a
treedb802c8f1adedf5e68bbd1591c5404a59c1a5efa
parent7ed1a747e51269c58ada4929c5d3f6094ded753e
[ORC] fix use-after-free detected by -Wreturn-stack-address

Summary:
llvm/lib/ExecutionEngine/Orc/Layer.cpp:53:12: warning: returning address of local temporary object [-Wreturn-stack-address]

In
```
StringRef IRMaterializationUnit::getName() const {
[...]
     return TSM.withModuleDo(
        [](const Module &M) { return M.getModuleIdentifier(); });
```
`getModuleIdentifier()` returns a `const std::string &`, but the implicit return type
of the lambda is `std::string` by value, and thus the returned `StringRef` refers
to a temporary `std::string`.

Detect by annotating `llvm::StringRef` with `[[gsl::Pointer]]`.

Reviewers: lhames, sgraenitz

Subscribers: hiraditya, llvm-commits

Tags: #llvm

Differential Revision: https://reviews.llvm.org/D66440

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@369306 91177308-0d34-0410-b5e6-96231b3b80d8
lib/ExecutionEngine/Orc/Layer.cpp