]> granicus.if.org Git - python/commit
Merge: #17443: Fix buffering in IMAP4_stream.
authorR David Murray <rdmurray@bitdance.com>
Tue, 19 Mar 2013 17:56:54 +0000 (13:56 -0400)
committerR David Murray <rdmurray@bitdance.com>
Tue, 19 Mar 2013 17:56:54 +0000 (13:56 -0400)
commit660e89b163b52de6fbcdb4b0d963b2baf4da1d9d
treee75f8002c52874b5195a078169ffa492b3c83dec
parented1fe6be061d3c0be9d8b7735b65bd17db07850c
parent7889944b83cf04cefb45cd658644298218eac5db
Merge: #17443: Fix buffering in IMAP4_stream.

In Python2 Popen uses *FILE objects, which wind up buffering even though
subprocess defaults to no buffering.  In Python3, subprocess streams really
are unbuffered by default, but the imaplib code assumes read is buffered.  This
patch uses the default buffer size from the io module to get buffered streams
from Popen.

Much debugging work and patch by Diane Trout.

The imap protocol is too complicated to write a test for this simple
change with our current level of test infrastructure.
Lib/imaplib.py
Misc/ACKS
Misc/NEWS