]> granicus.if.org Git - postgresql/commit
Avoid platform-specific null pointer dereference in psql.
authorTom Lane <tgl@sss.pgh.pa.us>
Sun, 25 Aug 2019 19:04:04 +0000 (15:04 -0400)
committerTom Lane <tgl@sss.pgh.pa.us>
Sun, 25 Aug 2019 19:04:04 +0000 (15:04 -0400)
commit65b1cad5a0929e685e79f7e84f56e0f28a54107a
treeefb2e0f95685a32191a222e179d5b35ba845e0ed
parent9f4bf6d2af1ef4a69a789b65c9763fd13bca52d5
Avoid platform-specific null pointer dereference in psql.

POSIX permits getopt() to advance optind beyond argc when the last
argv entry is an option that requires an argument and hasn't got one.
It seems that no major platforms actually do that, but musl does,
so that something like "psql -f" would crash with that libc.
Add a check that optind is in range before trying to look at the
possibly-bogus option.

Report and fix by Quentin Rameau.  Back-patch to all supported
branches.

Discussion: https://postgr.es/m/20190825100617.GA6087@fifth.space
src/bin/psql/startup.c