]> granicus.if.org Git - postgresql/commit
Try to fix portability issue in enum renumbering (again).
authorTom Lane <tgl@sss.pgh.pa.us>
Wed, 31 Aug 2016 17:58:01 +0000 (13:58 -0400)
committerTom Lane <tgl@sss.pgh.pa.us>
Wed, 31 Aug 2016 17:58:01 +0000 (13:58 -0400)
commit65a588b4c3b06aefe0b00d6222598d4cff3542c2
tree08684c0af1d997a90d7e66eeb8f42022fc79d434
parent679226337ac3f44e784de0a95a8599dfd86401e8
Try to fix portability issue in enum renumbering (again).

The hack embodied in commit 4ba61a487 no longer works after today's change
to allow DatumGetFloat4/Float4GetDatum to be inlined (commit 14cca1bf8).
Probably what's happening is that the faulty compilers are deciding that
the now-inlined assignment is a no-op and so they're not required to
round to float4 width.

We had a bunch of similar issues earlier this year in the degree-based
trig functions, and eventually settled on using volatile intermediate
variables as the least ugly method of forcing recalcitrant compilers
to do what the C standard says (cf commit 82311bcdd).  Let's see if
that method works here.

Discussion: <4640.1472664476@sss.pgh.pa.us>
src/backend/catalog/pg_enum.c