]> granicus.if.org Git - postgresql/commit
Fix archive_cleanup_command.
authorHeikki Linnakangas <heikki.linnakangas@iki.fi>
Mon, 19 Nov 2012 08:02:25 +0000 (10:02 +0200)
committerHeikki Linnakangas <heikki.linnakangas@iki.fi>
Mon, 19 Nov 2012 08:14:20 +0000 (10:14 +0200)
commit644a0a6379afc00803dd89ffe8416514f5dfc217
treeda387d3319795781f31d8448d2d101cead2e3151
parentb6e3798f3aa2747db145f25e03a8d34f2e5ec8c8
Fix archive_cleanup_command.

When I moved ExecuteRecoveryCommand() from xlog.c to xlogarchive.c, I didn't
realize that it's called from the checkpoint process, not the startup
process. I tried to use InRedo variable to decide whether or not to attempt
cleaning up the archive (must not do so before we have read the initial
checkpoint record), but that variable is only valid within the startup
process.

Instead, let ExecuteRecoveryCommand() always clean up the archive, and add
an explicit argument to RestoreArchivedFile() to say whether that's allowed
or not. The caller knows better.

Reported by Erik Rijkers, diagnosis by Fujii Masao. Only 9.3devel is
affected.
src/backend/access/transam/timeline.c
src/backend/access/transam/xlog.c
src/backend/access/transam/xlogarchive.c
src/include/access/xlog_internal.h