]> granicus.if.org Git - postgresql/commit
Prevent failure when RowExpr or XmlExpr is parse-analyzed twice.
authorTom Lane <tgl@sss.pgh.pa.us>
Sun, 23 Dec 2012 19:07:36 +0000 (14:07 -0500)
committerTom Lane <tgl@sss.pgh.pa.us>
Sun, 23 Dec 2012 19:07:36 +0000 (14:07 -0500)
commit628ea7ea51e046bade9ce7f15dc9c41118e29f13
tree498d460f6ca04d23a76f651928c05e04a7f3a6f9
parent14aa55df29ea69e453be4c46f8546d49365fc06b
Prevent failure when RowExpr or XmlExpr is parse-analyzed twice.

transformExpr() is required to cope with already-transformed expression
trees, for various ugly-but-not-quite-worth-cleaning-up reasons.  However,
some of its newer subroutines hadn't gotten the memo.  This accounts for
bug #7763 from Norbert Buchmuller: transformRowExpr() was overwriting the
previously determined type of a RowExpr during CREATE TABLE LIKE INCLUDING
INDEXES.  Additional investigation showed that transformXmlExpr had the
same kind of problem, but all the other cases seem to be safe.

Andres Freund and Tom Lane
src/backend/parser/gram.y
src/backend/parser/parse_expr.c
src/include/nodes/primnodes.h