]> granicus.if.org Git - postgresql/commit
Keep rs_startblock the same during heap_rescan, so that a rescan of a SeqScan
authorTom Lane <tgl@sss.pgh.pa.us>
Wed, 10 Jun 2009 18:54:16 +0000 (18:54 +0000)
committerTom Lane <tgl@sss.pgh.pa.us>
Wed, 10 Jun 2009 18:54:16 +0000 (18:54 +0000)
commit61dd4185ffb034a22b4b40425d56fe37e7178488
treed72a8e75fc09a0e92ce1bd6712f579d1c0d28a19
parent2ef8c1acfd5a1f81020c3eb2916f9dcfaeeec48c
Keep rs_startblock the same during heap_rescan, so that a rescan of a SeqScan
node starts from the same place as the first scan did.  This avoids surprising
behavior of scrollable and WITH HOLD cursors, as seen in Mark Kirkwood's bug
report of yesterday.

It's not entirely clear whether a rescan should be forced to drop out of the
syncscan mode, but for the moment I left the code behaving the same on that
point.  Any change there would only be a performance and not a correctness
issue, anyway.

Back-patch to 8.3, since the unstable behavior was created by the syncscan
patch.
src/backend/access/heap/heapam.c