]> granicus.if.org Git - postgresql/commit
Move permissions check from do_pg_start_backup to pg_start_backup
authorMagnus Hagander <magnus@hagander.net>
Tue, 7 Jan 2014 16:47:52 +0000 (17:47 +0100)
committerMagnus Hagander <magnus@hagander.net>
Tue, 7 Jan 2014 16:53:00 +0000 (17:53 +0100)
commit61d4d14ee55534dd9fead189a5a339ecdf04e82a
treefb8443ae522e6e7a81a45b83910ceec651f49947
parent2edf3e82c5e23bf9095cab5c7c19578d46a13e48
Move permissions check from do_pg_start_backup to pg_start_backup

And the same for do_pg_stop_backup. The code in do_pg_* is not allowed
to access the catalogs. For manual base backups, the permissions
check can be handled in the calling function, and for streaming
base backups only users with the required permissions can get past
the authentication step in the first place.

Reported by Antonin Houska, diagnosed by Andres Freund
src/backend/access/transam/xlog.c
src/backend/access/transam/xlogfuncs.c