]> granicus.if.org Git - postgresql/commit
pg_dump: Fix dumping of WITH OIDS tables
authorPeter Eisentraut <peter_e@gmx.net>
Fri, 9 Nov 2018 08:17:25 +0000 (09:17 +0100)
committerPeter Eisentraut <peter_e@gmx.net>
Tue, 13 Nov 2018 08:41:20 +0000 (09:41 +0100)
commit6178f3cb798f2ea9011c55e99973f838719c550e
treed0b3920945012413562ea74b94160fcf1afa1095
parentb59d4d6c36e14ba4097fa8dac3d31ca86f7f507d
pg_dump: Fix dumping of WITH OIDS tables

A table with OIDs that was the first in the dump output would not get
dumped with OIDs enabled.  Fix that.

The reason was that the currWithOids flag was declared to be bool but
actually also takes a -1 value for "don't know yet".  But under
stdbool.h semantics, that is coerced to true, so the required SET
default_with_oids command is not output again.  Change the variable
type to char to fix that.

Reported-by: Derek Nelson <derek@pipelinedb.com>
src/bin/pg_dump/pg_backup_archiver.h