]> granicus.if.org Git - clang/commit
[analyzer] Don't delete TaintConfig copy constructor
authorAlex Langford <apl@fb.com>
Wed, 14 Aug 2019 01:09:07 +0000 (01:09 +0000)
committerAlex Langford <apl@fb.com>
Wed, 14 Aug 2019 01:09:07 +0000 (01:09 +0000)
commit615bedd92154f50c53a905d3f4ceb61d30a6609c
treef587d37e0c8991e8cb6902da45ef2ba90cf7a0dd
parent4df908a46a231621f2322027d6ca20e48a8bec1a
[analyzer] Don't delete TaintConfig copy constructor

Summary:
Explicitly deleting the copy constructor makes compiling the function
`ento::registerGenericTaintChecker` difficult with some compilers. When we
construct an `llvm::Optional<TaintConfig>`, the optional is constructed with a
const TaintConfig reference which it then uses to invoke the deleted TaintConfig
copy constructor.

I've observered this failing with clang 3.8 on Ubuntu 16.04.

Reviewers: compnerd, Szelethus, boga95, NoQ, alexshap

Subscribers: xazax.hun, baloghadamsoftware, szepet, a.sidorin, mikhail.ramalho, donat.nagy, dkrupp, Charusso, llvm-commits, cfe-commits

Tags: #clang

Differential Revision: https://reviews.llvm.org/D66192

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@368779 91177308-0d34-0410-b5e6-96231b3b80d8
lib/StaticAnalyzer/Checkers/GenericTaintChecker.cpp