]> granicus.if.org Git - llvm/commit
Merging r323331:
authorHans Wennborg <hans@hanshq.net>
Tue, 30 Jan 2018 09:48:42 +0000 (09:48 +0000)
committerHans Wennborg <hans@hanshq.net>
Tue, 30 Jan 2018 09:48:42 +0000 (09:48 +0000)
commit6148a4925e2eef4a34f61c9f379bb81d61e8eac1
tree8141c9fc18ae81cdf9918cd7c1155e4e631d187a
parent98b79f2cd78d57b8e5f5307ac889fa264cddcc36
Merging r323331:
------------------------------------------------------------------------
r323331 | spatel | 2018-01-24 16:20:37 +0100 (Wed, 24 Jan 2018) | 21 lines

[ValueTracking] add recursion depth param to matchSelectPattern

We're getting bug reports:
https://bugs.llvm.org/show_bug.cgi?id=35807
https://bugs.llvm.org/show_bug.cgi?id=35840
https://bugs.llvm.org/show_bug.cgi?id=36045
...where we blow up the stack in value tracking because other passes are sending
in selects that have an operand that is itself the select.

We don't currently have a reliable way to avoid analyzing dead code that may take
non-standard forms, so bail out when things go too far.

This mimics the recursion depth limitations in other parts of value tracking.

Unfortunately, this pushes the underlying problems for other passes (jump-threading,
simplifycfg, correlated-propagation) into hiding. If someone wants to uncover those
again, the first draft of this patch on Phab would do that (it would assert rather
than bail out).

Differential Revision: https://reviews.llvm.org/D42442

------------------------------------------------------------------------

git-svn-id: https://llvm.org/svn/llvm-project/llvm/branches/release_60@323737 91177308-0d34-0410-b5e6-96231b3b80d8
include/llvm/Analysis/ValueTracking.h
lib/Analysis/ValueTracking.cpp
test/Analysis/ValueTracking/select-pattern.ll [new file with mode: 0644]