ntlm_wb: Fix theoretical memory leak
authorDavid Woodhouse <David.Woodhouse@intel.com>
Thu, 16 Jul 2015 18:17:33 +0000 (14:17 -0400)
committerJay Satiro <raysatiro@yahoo.com>
Thu, 16 Jul 2015 18:22:45 +0000 (14:22 -0400)
commit60b19630b032d99270282e021216605718acc14d
treef26ed6457467669696532cee96d8f9c7d8b3e731
parentde74e856e63b0c6fd1e36d96d6310672abf12c29
ntlm_wb: Fix theoretical memory leak

Static analysis indicated that my commit 9008f3d564 ("ntlm_wb: Fix
hard-coded limit on NTLM auth packet size") introduced a potential
memory leak on an error path, because we forget to free the buffer
before returning an error.

Fix this.

Although actually, it never happens in practice because we never *get*
here with state == NTLMSTATE_TYPE1. The state is always zero. That
might want cleaning up in a separate patch.

Reported-by: Terri Oda
lib/curl_ntlm_wb.c