]> granicus.if.org Git - postgresql/commit
Improve code around the recently added rm_identify rmgr callback.
authorAndres Freund <andres@anarazel.de>
Mon, 22 Sep 2014 14:48:14 +0000 (16:48 +0200)
committerAndres Freund <andres@anarazel.de>
Mon, 22 Sep 2014 15:49:34 +0000 (17:49 +0200)
commit604f7956b9460192222dd37bd3baea24cb669a47
treeb5724bd4bcb4a36e51c1fdd90edeb162edb30d24
parent898f8a96ef9dfa79eac9ec1621a89e71fe16601c
Improve code around the recently added rm_identify rmgr callback.

There are four weaknesses in728f152e07f998d2cb4fe5f24ec8da2c3bda98f2:

* append_init() in heapdesc.c was ugly and required that rm_identify
  return values are only valid till the next call. Instead just add a
  couple more switch() cases for the INIT_PAGE cases. Now the returned
  value will always be valid.
* a couple rm_identify() callbacks missed masking xl_info with
  ~XLR_INFO_MASK.
* pg_xlogdump didn't map a NULL rm_identify to UNKNOWN or a similar
  string.
* append_init() was called when id=NULL - which should never actually
  happen. But it's better to be careful.
18 files changed:
contrib/pg_xlogdump/pg_xlogdump.c
src/backend/access/rmgrdesc/clogdesc.c
src/backend/access/rmgrdesc/dbasedesc.c
src/backend/access/rmgrdesc/gindesc.c
src/backend/access/rmgrdesc/gistdesc.c
src/backend/access/rmgrdesc/heapdesc.c
src/backend/access/rmgrdesc/mxactdesc.c
src/backend/access/rmgrdesc/nbtdesc.c
src/backend/access/rmgrdesc/relmapdesc.c
src/backend/access/rmgrdesc/seqdesc.c
src/backend/access/rmgrdesc/smgrdesc.c
src/backend/access/rmgrdesc/spgdesc.c
src/backend/access/rmgrdesc/standbydesc.c
src/backend/access/rmgrdesc/tblspcdesc.c
src/backend/access/rmgrdesc/xactdesc.c
src/backend/access/rmgrdesc/xlogdesc.c
src/backend/access/transam/xlog.c
src/include/access/xlog_internal.h