]> granicus.if.org Git - postgresql/commit
Avoid platform-specific null pointer dereference in psql.
authorTom Lane <tgl@sss.pgh.pa.us>
Sun, 25 Aug 2019 19:04:04 +0000 (15:04 -0400)
committerTom Lane <tgl@sss.pgh.pa.us>
Sun, 25 Aug 2019 19:04:04 +0000 (15:04 -0400)
commit5fc7b1e939c432439f7c74885b7d053e5c1cab6f
treea02074628d2eea903baa8a54a4375c3232986d0d
parentee18293a4e722e7681e264dfeab9f0af24d4adb1
Avoid platform-specific null pointer dereference in psql.

POSIX permits getopt() to advance optind beyond argc when the last
argv entry is an option that requires an argument and hasn't got one.
It seems that no major platforms actually do that, but musl does,
so that something like "psql -f" would crash with that libc.
Add a check that optind is in range before trying to look at the
possibly-bogus option.

Report and fix by Quentin Rameau.  Back-patch to all supported
branches.

Discussion: https://postgr.es/m/20190825100617.GA6087@fifth.space
src/bin/psql/startup.c