]> granicus.if.org Git - clang/commit
[coroutines] Fix application of NRVO to Coroutine "Gro" or return object.
authorEric Fiselier <eric@efcs.ca>
Thu, 1 Feb 2018 23:47:54 +0000 (23:47 +0000)
committerEric Fiselier <eric@efcs.ca>
Thu, 1 Feb 2018 23:47:54 +0000 (23:47 +0000)
commit5fb3bb840451f64825c8c310b7a22ac84740667d
treeb5f6d746e163fbd6b37026b81ea6f2ee0e5ec432
parentde212366a3b025425ef488b469f40125a1c61549
[coroutines] Fix application of NRVO to Coroutine "Gro" or return object.

Summary:
Fix NRVO for Gro variable.

Previously, we only marked the GRO declaration as an NRVO variable
when its QualType and the function return's QualType matched exactly
(using operator==). However, this was incorrect for two reasons:

1. We were marking non-class types, such as ints, as being NRVO variables.

2. We failed to  handle cases where the canonical types were the same, but the actual `QualType` objects were different. For example, if  one was represented by a typedef. (Example: https://godbolt.org/g/3UFgsL)

This patch fixes these bugs by marking the Gro variable as supporting NRVO only
when `BuildReturnStmt` marks the Gro variable as a coroutine candidate.

Reviewers: rsmith, GorNishanov, nicholas

Reviewed By: GorNishanov

Subscribers: majnemer, cfe-commits

Differential Revision: https://reviews.llvm.org/D42343

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@324037 91177308-0d34-0410-b5e6-96231b3b80d8
lib/Sema/SemaCoroutine.cpp
test/CodeGenCoroutines/coro-alloc.cpp
test/CodeGenCoroutines/coro-gro-nrvo.cpp [new file with mode: 0644]