]> granicus.if.org Git - postgresql/commit
sum() on int2 and int4 columns now uses an int8, not numeric, accumulator
authorTom Lane <tgl@sss.pgh.pa.us>
Tue, 14 Aug 2001 22:21:59 +0000 (22:21 +0000)
committerTom Lane <tgl@sss.pgh.pa.us>
Tue, 14 Aug 2001 22:21:59 +0000 (22:21 +0000)
commit5f7c2bdb537bd18fd7f1cc942950e7e64c6e0a92
treedeb73ae98b59fb4315f82b781a7c22859cbccd00
parent6f2943b52e9f4af3c4488c0373a3490e38c032a7
sum() on int2 and int4 columns now uses an int8, not numeric, accumulator
for speed reasons; its result type also changes to int8.  avg() on these
datatypes now accumulates the running sum in int8 for speed; but we still
deliver the final result as numeric, so that fractional accuracy is
preserved.

count() now counts and returns in int8, not int4.  I am a little nervous
about this possibly breaking users' code, but there didn't seem to be
a strong sentiment for avoiding the problem.  If we get complaints during
beta, we can change count back to int4 and add a "count8" aggregate.
For that matter, users can do it for themselves with a simple CREATE
AGGREGATE command; the int4inc function is still present, so no C hacking
is needed.

Also added max() and min() aggregates for OID that do proper unsigned
comparison, instead of piggybacking on int4 aggregates.

initdb forced.
13 files changed:
doc/src/sgml/func.sgml
src/backend/utils/adt/int8.c
src/backend/utils/adt/numeric.c
src/backend/utils/adt/oid.c
src/backend/utils/fmgr/fmgr.c
src/include/catalog/catversion.h
src/include/catalog/pg_aggregate.h
src/include/catalog/pg_proc.h
src/include/utils/builtins.h
src/include/utils/int8.h
src/test/regress/expected/opr_sanity.out
src/test/regress/expected/rules.out
src/test/regress/sql/rules.sql