]> granicus.if.org Git - postgresql/commit
Fix pg_dump to handle inherited NOT VALID check constraints correctly.
authorTom Lane <tgl@sss.pgh.pa.us>
Thu, 1 Oct 2015 20:19:49 +0000 (16:19 -0400)
committerTom Lane <tgl@sss.pgh.pa.us>
Thu, 1 Oct 2015 20:20:15 +0000 (16:20 -0400)
commit5ea47e8f2a7d524eb491b1ffffbc98a012745409
tree0e26a5f1256ca4af8d6a5338604f228357f56ad2
parenta742ef86c228d8a0e9d174c651cfc4f96ac77e61
Fix pg_dump to handle inherited NOT VALID check constraints correctly.

This case seems to have been overlooked when unvalidated check constraints
were introduced, in 9.2.  The code would attempt to dump such constraints
over again for each child table, even though adding them to the parent
table is sufficient.

In 9.2 and 9.3, also fix contrib/pg_upgrade/Makefile so that the "make
clean" target fully cleans up after a failed test.  This evidently got
dealt with at some point in 9.4, but it wasn't back-patched.  I ran into
it while testing this fix ...

Per bug #13656 from Ingmar Brouns.
src/bin/pg_dump/pg_dump.c
src/test/regress/expected/alter_table.out
src/test/regress/sql/alter_table.sql