]> granicus.if.org Git - postgresql/commit
Fix an old bug in multixact and two-phase commit. Prepared transactions can
authorHeikki Linnakangas <heikki.linnakangas@iki.fi>
Mon, 23 Nov 2009 09:58:51 +0000 (09:58 +0000)
committerHeikki Linnakangas <heikki.linnakangas@iki.fi>
Mon, 23 Nov 2009 09:58:51 +0000 (09:58 +0000)
commit5e4b869f29ea13729dd4e4200c08702d9c91828d
tree0e99e9b45fff37a99f123609247affcfbe0bc327
parent1e925f49e7e885dbf3df81e275144b1e285acef6
Fix an old bug in multixact and two-phase commit. Prepared transactions can
be part of multixacts, so allocate a slot for each prepared transaction in
the "oldest member" array in multixact.c. On PREPARE TRANSACTION, transfer
the oldest member value from the current backends slot to the prepared xact
slot. Also save and recover the value from the 2pc state file.

The symptom of the bug was that after a transaction prepared, a shared lock
still held by the prepared transaction was sometimes ignored by other
transactions.

Fix back to 8.1, where both 2PC and multixact were introduced.
src/backend/access/transam/multixact.c
src/backend/access/transam/twophase.c
src/backend/access/transam/twophase_rmgr.c
src/backend/access/transam/xact.c
src/include/access/multixact.h
src/include/access/twophase.h
src/include/access/twophase_rmgr.h