Use binary search instead of brute-force scan in findNamespace().
authorTom Lane <tgl@sss.pgh.pa.us>
Fri, 25 May 2012 18:35:53 +0000 (14:35 -0400)
committerTom Lane <tgl@sss.pgh.pa.us>
Fri, 25 May 2012 18:35:53 +0000 (14:35 -0400)
commit5e0f3c793a3767f38498d9cd54a3bfeeccdce6bf
tree368300492af34d0174fe34e8441355033010f1ba
parent3ce6fa5568a3d554551cfec4167a9f55510a9468
Use binary search instead of brute-force scan in findNamespace().

The previous coding presented a significant bottleneck when dumping
databases containing many thousands of schemas, since the total time
spent searching would increase roughly as O(N^2) in the number of objects.
Noted by Jeff Janes, though I rewrote his proposed patch to use the
existing findObjectByOid infrastructure.

Since this is a longstanding performance bug, backpatch to all supported
versions.
src/bin/pg_dump/common.c
src/bin/pg_dump/pg_dump.c
src/bin/pg_dump/pg_dump.h