]> granicus.if.org Git - python/commit
Repair widespread misuse of _PyString_Resize. Since it's clear people
authorTim Peters <tim.peters@gmail.com>
Sat, 27 Apr 2002 18:44:32 +0000 (18:44 +0000)
committerTim Peters <tim.peters@gmail.com>
Sat, 27 Apr 2002 18:44:32 +0000 (18:44 +0000)
commit5de9842b34cbefbfe74e6a99004616352f223133
treea4e980e6833ab279d0eff942e6c9cbcfaf1f4d63
parent602f740bc2da44ce25c22b7b4b5a7a4fb3435a5a
Repair widespread misuse of _PyString_Resize.  Since it's clear people
don't understand how this function works, also beefed up the docs.  The
most common usage error is of this form (often spread out across gotos):

if (_PyString_Resize(&s, n) < 0) {
Py_DECREF(s);
s = NULL;
goto outtahere;
}

The error is that if _PyString_Resize runs out of memory, it automatically
decrefs the input string object s (which also deallocates it, since its
refcount must be 1 upon entry), and sets s to NULL.  So if the "if"
branch ever triggers, it's an error to call Py_DECREF(s):  s is already
NULL!  A correct way to write the above is the simpler (and intended)

if (_PyString_Resize(&s, n) < 0)
goto outtahere;

Bugfix candidate.
14 files changed:
Doc/api/concrete.tex
Modules/_ssl.c
Modules/cPickle.c
Modules/cdmodule.c
Modules/clmodule.c
Modules/linuxaudiodev.c
Modules/regexmodule.c
Modules/socketmodule.c
Modules/stropmodule.c
Modules/zlibmodule.c
Objects/fileobject.c
Objects/stringobject.c
Objects/unicodeobject.c
Python/bltinmodule.c