]> granicus.if.org Git - postgresql/commit
Use snprintf not sprintf in pg_waldump's timestamptz_to_str.
authorTom Lane <tgl@sss.pgh.pa.us>
Sat, 16 Jun 2018 18:45:47 +0000 (14:45 -0400)
committerTom Lane <tgl@sss.pgh.pa.us>
Sat, 16 Jun 2018 18:45:47 +0000 (14:45 -0400)
commit5d923eb29bb643e311680bab329363d8a9a9768a
treef5951e2418dadd03f7f1b1d61b0ed3b29d616118
parent0dcf68e5a1f1c600bdf29b47cab30a62301a7af1
Use snprintf not sprintf in pg_waldump's timestamptz_to_str.

This could only cause an issue if strftime returned a ridiculously
long timezone name, which seems unlikely; and it wouldn't qualify
as a security problem even then, since pg_waldump (nee pg_xlogdump)
is a debug tool not part of the server.  But gcc 8 has started issuing
warnings about it, so let's use snprintf and be safe.

Backpatch to 9.3 where this code was added.

Discussion: https://postgr.es/m/21789.1529170195@sss.pgh.pa.us
src/bin/pg_waldump/compat.c