]> granicus.if.org Git - postgresql/commit
Clear OpenSSL error queue after failed X509_STORE_load_locations() call.
authorHeikki Linnakangas <heikki.linnakangas@iki.fi>
Fri, 7 Oct 2016 09:53:49 +0000 (12:53 +0300)
committerHeikki Linnakangas <heikki.linnakangas@iki.fi>
Fri, 7 Oct 2016 09:53:49 +0000 (12:53 +0300)
commit5d5dc6f68aeff20822ae28fae6c51f634c878278
tree423c8ab5e98533439dab7d5dbf9bb5771f587f90
parente7bb327e347212172b7db16af6721c39090aa5c5
Clear OpenSSL error queue after failed X509_STORE_load_locations() call.

Leaving the error in the error queue used to be harmless, because the
X509_STORE_load_locations() call used to be the last step in
initialize_SSL(), and we would clear the queue before the next
SSL_connect() call. But previous commit moved things around. The symptom
was that if a CRL file was not found, and one of the subsequent
initialization steps, like loading the client certificate or private key,
failed, we would incorrectly print the "no such file" error message from
the earlier X509_STORE_load_locations() call as the reason.

Backpatch to all supported versions, like the previous patch.
src/interfaces/libpq/fe-secure.c