]> granicus.if.org Git - apache/commit
Fix a bug in the input handling. ap_http_filter() was modifying *readbytes
authorGreg Stein <gstein@apache.org>
Sat, 5 May 2001 11:18:01 +0000 (11:18 +0000)
committerGreg Stein <gstein@apache.org>
Sat, 5 May 2001 11:18:01 +0000 (11:18 +0000)
commit5cba6d73451776b74be01f400b9d06ef7089ebc0
tree713092ebac49f89de781129086d7dab5a467f5f3
parentb4f8ab5b11d0414e158ce5fcf1e7169ef1bb002d
Fix a bug in the input handling. ap_http_filter() was modifying *readbytes
which corresponded to r->remaining (in ap_get_client_block). However,
ap_get_client_block was *also* adjusting r->remaining. Net result was that
PUT (and probably POST) was broken. (at least on large inputs)

To fix it, I simply removed the indirection on "readbytes" for input
filters. There is no reason for them to return data (the brigade length is
the return length). This also simplifies a number of calls where people
needed to do &zero just to pass zero.

I also added a number of comments about operations and where things could be
improved, or are (semi) broken.

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@89008 13f79535-47bb-0310-9956-ffa450edef68
12 files changed:
include/util_filter.h
modules/experimental/mod_charset_lite.c
modules/experimental/mod_ext_filter.c
modules/http/http_protocol.c
modules/http/http_request.c
modules/http/mod_core.h
modules/tls/mod_tls.c
server/core.c
server/mpm/experimental/perchild/perchild.c
server/mpm/perchild/perchild.c
server/protocol.c
server/util_filter.c