]> granicus.if.org Git - postgresql/commit
Correct some code in pg_restore when reading the header of a tar archive:
authorNeil Conway <neilc@samurai.com>
Wed, 22 Jun 2005 02:02:09 +0000 (02:02 +0000)
committerNeil Conway <neilc@samurai.com>
Wed, 22 Jun 2005 02:02:09 +0000 (02:02 +0000)
commit5ba26d48fc03eef2083768672548bde0bb6ddbbe
tree80b057d337869a2867f1409e8690654bd39d6287
parent5bcb851c92ae273a83dd5e314995941455d226ae
Correct some code in pg_restore when reading the header of a tar archive:

(1) The code doesn't initialize `sum', so the initial "does the checksum
    match?" test is wrong.

(2) The loop that is intended to check for a "null block" just checks
    the first byte of the tar block 512 times, rather than each of the
    512 bytes one time (!), which I'm guessing was the intent.

It was only through sheer luck that this worked in the first place.

Per Coverity static analysis performed by EnterpriseDB.
src/bin/pg_dump/pg_backup_tar.c