]> granicus.if.org Git - clang/commit
Change subexpressions to be visited in the CFG from left-to-right.
authorTed Kremenek <kremenek@apple.com>
Tue, 5 Feb 2013 22:00:19 +0000 (22:00 +0000)
committerTed Kremenek <kremenek@apple.com>
Tue, 5 Feb 2013 22:00:19 +0000 (22:00 +0000)
commit5846720f08a6b225484bfe663599c2b057a99bc8
treef7344dc87cee63b004193048ecc9e9839c5ace49
parent9b0e9ed41dee29281f7bfd1209a7ebf3b2bbfddc
Change subexpressions to be visited in the CFG from left-to-right.

This is a more natural order of evaluation, and it is very important
for visualization in the static analyzer.  Within Xcode, the arrows
will not jump from right to left, which looks very visually jarring.
It also provides a more natural location for dataflow-based diagnostics.

Along the way, we found a case in the analyzer diagnostics where we
needed to indicate that a variable was "captured" by a block.

-fsyntax-only timings on sqlite3.c show no visible performance change,
although this is just one test case.

Fixes <rdar://problem/13016513>

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@174447 91177308-0d34-0410-b5e6-96231b3b80d8
include/clang/AST/Expr.h
include/clang/StaticAnalyzer/Core/PathSensitive/MemRegion.h
lib/Analysis/CFG.cpp
lib/StaticAnalyzer/Core/BugReporterVisitors.cpp
lib/StaticAnalyzer/Core/MemRegion.cpp
test/Analysis/temp-obj-dtors-cfg-output.cpp
test/Analysis/unix-fns.c
test/Sema/warn-unreachable.c