]> granicus.if.org Git - python/commit
bpo-32844: Fix a subprocess misredirection of a low fd (GH5689)
authorMiss Islington (bot) <31488909+miss-islington@users.noreply.github.com>
Mon, 26 Mar 2018 20:43:46 +0000 (13:43 -0700)
committerGitHub <noreply@github.com>
Mon, 26 Mar 2018 20:43:46 +0000 (13:43 -0700)
commit57db13e582ad269d6e067fe934122207cc992739
treeebd3432694b1bb0167640955f48a3bd2c8177632
parenta413a91949e5472aee518a89a61cc21af4b49e3b
bpo-32844: Fix a subprocess misredirection of a low fd (GH5689)

bpo-32844: subprocess: Fix a potential misredirection of a low fd to stderr.

When redirecting, subprocess attempts to achieve the following state:
each fd to be redirected to is less than or equal to the fd
it is redirected from, which is necessary because redirection
occurs in the ascending order of destination descriptors.
It fails to do so in a couple of corner cases,
for example, if 1 is redirected to 2 and 0 is closed in the parent.
(cherry picked from commit 0e7144b064a19493a146af94175a087b3888c37b)

Co-authored-by: Alexey Izbyshev <izbyshev@users.noreply.github.com>
Lib/test/test_subprocess.py
Misc/NEWS.d/next/Library/2018-02-28-13-08-00.bpo-32844.u8tnAe.rst [new file with mode: 0644]
Modules/_posixsubprocess.c