]> granicus.if.org Git - postgresql/commit
Remove dead code in pg_dump.
authorTom Lane <tgl@sss.pgh.pa.us>
Sun, 17 Jan 2016 16:38:40 +0000 (11:38 -0500)
committerTom Lane <tgl@sss.pgh.pa.us>
Sun, 17 Jan 2016 16:38:40 +0000 (11:38 -0500)
commit57ce9acc04483df4913921d4ff21f01483583fb8
tree99ec3fb2fc8aae11556ab294b89d0b9028edda41
parent4189e3d659abb48d159a6c3faabaa7e99498ca3e
Remove dead code in pg_dump.

Coverity quite reasonably complained that this check for fout==NULL
occurred after we'd already dereferenced fout.  However, the check
is just dead code since there is no code path by which CreateArchive
can return a null pointer.  Errors such as can't-open-that-file are
reported down inside CreateArchive, and control doesn't return.
So let's silence the warning by removing the dead code, rather than
continuing to pretend it does something.

Coverity didn't complain about this before 5b5fea2a1, so back-patch
to 9.5 like that patch.
src/bin/pg_dump/pg_dump.c