]> granicus.if.org Git - llvm/commit
[RISCV] Fix uninitialized variable after call to evaluateConstantImm
authorFrancis Visoiu Mistrih <francisvm@yahoo.com>
Mon, 29 Jul 2019 15:52:13 +0000 (15:52 +0000)
committerFrancis Visoiu Mistrih <francisvm@yahoo.com>
Mon, 29 Jul 2019 15:52:13 +0000 (15:52 +0000)
commit57c9c447309dd75ea7caebd12b944e3afb6cd9d9
tree65cd9ab6a11b97acfc9f2ed57c9fc44530e50619
parentd76b11b54b8d2025dd2b1604f191d75da41cd3eb
[RISCV] Fix uninitialized variable after call to evaluateConstantImm

For llvm/test/MC/RISCV/rv64i-aliases-invalid.s, UBSan reports:

lib/Target/RISCV/AsmParser/RISCVAsmParser.cpp:371:9: runtime error:
load of value 3879186881, which is not a valid value for type
'RISCVMCExpr::VariantKind'
SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior
lib/Target/RISCV/AsmParser/RISCVAsmParser.cpp:371:9 in

It turns out that evaluateConstantImm does not set `VK` and it remains
unitialized when doing comparisons in `isImmXLenLI()`.

Differential Revision: https://reviews.llvm.org/D65347

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@367230 91177308-0d34-0410-b5e6-96231b3b80d8
lib/Target/RISCV/AsmParser/RISCVAsmParser.cpp