]> granicus.if.org Git - postgresql/commit
Fix handling of all-zero pages in SP-GiST vacuum.
authorHeikki Linnakangas <heikki.linnakangas@iki.fi>
Mon, 27 Jul 2015 09:28:21 +0000 (12:28 +0300)
committerHeikki Linnakangas <heikki.linnakangas@iki.fi>
Mon, 27 Jul 2015 09:32:08 +0000 (12:32 +0300)
commit579b9f97ce99c3ddc8e1de0e1b1f160da2e669c7
treed818b23e8b79b75edbd923c0400f726631f2d2de
parent491c24f055fd14032dee6ed75d43d3aa076add0e
Fix handling of all-zero pages in SP-GiST vacuum.

SP-GiST initialized an all-zeros page at vacuum, but that was not
WAL-logged, which is not safe. You might get a torn page write, when it gets
flushed to disk, and end-up with a half-initialized index page. To fix,
leave it in the all-zeros state, and add it to the FSM. It will be
initialized when reused. Also don't set the page-deleted flag when recycling
an empty page. That was also not WAL-logged, and a torn write of that would
cause the page to have an invalid checksum.

Backpatch to 9.2, where SP-GiST indexes were added.
src/backend/access/spgist/spgvacuum.c
src/include/access/spgist_private.h