]> granicus.if.org Git - clang/commit
PR38627: Fix handling of exception specification adjustment for
authorRichard Smith <richard-llvm@metafoo.co.uk>
Wed, 5 Sep 2018 22:30:37 +0000 (22:30 +0000)
committerRichard Smith <richard-llvm@metafoo.co.uk>
Wed, 5 Sep 2018 22:30:37 +0000 (22:30 +0000)
commit5786130f48520f80c14529cdbdf48968168b9a41
treef8d0e94401536c0099d92491aa417828297c1913
parentb9640bc0c266e2c5d2ec36828dc1ac66ab903112
PR38627: Fix handling of exception specification adjustment for
destructors.

We previously tried to patch up the exception specification after
completing the class, which went wrong when the exception specification
was needed within the class body (in particular, by a friend
redeclaration of the destructor in a nested class). We now mark the
destructor as having a not-yet-computed exception specification
immediately after creating it.

This requires delaying various checks against the exception
specification (where we'd previously have just got the wrong exception
specification, and now find we have an exception specification that we
can't compute yet) when those checks fire while the class is being
defined.

This also exposed an issue that we were missing a CodeSynthesisContext
for computation of exception specifications (otherwise we'd fail to make
the module containing the definition of the class visible when computing
its members' exception specs). Adding that incidentally also gives us a
diagnostic quality improvement.

This has also exposed an pre-existing problem: making the exception
specification evaluation context a non-SFINAE context (as it should be)
results in a bootstrap failure; PR38850 filed for this.

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@341499 91177308-0d34-0410-b5e6-96231b3b80d8
19 files changed:
include/clang/Basic/DiagnosticSemaKinds.td
include/clang/Sema/Sema.h
lib/Frontend/FrontendActions.cpp
lib/Sema/Sema.cpp
lib/Sema/SemaDecl.cpp
lib/Sema/SemaDeclCXX.cpp
lib/Sema/SemaExceptionSpec.cpp
lib/Sema/SemaTemplateInstantiate.cpp
lib/Sema/SemaTemplateInstantiateDecl.cpp
test/CXX/drs/dr13xx.cpp
test/CXX/expr/expr.prim/expr.prim.lambda/templates.cpp
test/Modules/cxx-templates.cpp
test/Modules/exception-spec.cpp [new file with mode: 0644]
test/SemaCXX/constant-expression-cxx11.cpp
test/SemaCXX/cxx0x-defaulted-functions.cpp
test/SemaCXX/exception-spec.cpp
test/SemaCXX/implicit-exception-spec.cpp
test/SemaCXX/member-init.cpp
test/SemaTemplate/instantiate-init.cpp