]> granicus.if.org Git - sysstat/commit
Make sysstat disk counters consistent with those from latest kernel (3.5).
authorSebastien <seb@kluane.home>
Thu, 19 Jul 2012 19:18:06 +0000 (21:18 +0200)
committerSebastien <seb@kluane.home>
Thu, 19 Jul 2012 19:18:06 +0000 (21:18 +0200)
commit57078424574814813a4f36141b8426cec1b3f7e7
tree6fcc2b7d8b1afc32643fe54662779f2084a2d70f
parent71e0e8079506906138c30c2dfaa3104d2d9e7feb
Make sysstat disk counters consistent with those from latest kernel (3.5).

Changed the type of some disk counters to keep in sync with latest 3.5
kernel.
This breaks the compatibility with older sar data files format for disk
activity.

Mail from Peter Schiffer (pschiffe@redhat.com) 15/02/2012:

I am sending you next patch. I've updated reading /proc/diskstats and
/sys/block/<disk>/stat files in iostat.c and rd_stats.c source files
according to latest kernel (3.2.6).

Problem was, that in case of very high I/O operations, sar -d and iostat
outputted overflowed values:

sar -d output:
09:20:01 PM       DEV       tps  rd_sec/s  wr_sec/s  avgrq-sz  avgqu-sz
await     svctm     %util
09:50:01 PM      sdb1   2986.02      0.05  34704.99     11.62   3355.91
1137.22      0.28     84.49
09:55:01 PM      sdb1   3284.08      0.21  32884.03     10.01   4556.98
1386.29      0.27     88.31
10:00:01 PM      sdb1   3260.33      0.19  31497.61      9.66
61474802782539.38
18855397092136.58      0.27     87.60
10:05:01 PM      sdb1   3373.57      0.08  32028.26      9.49   6069.53
1799.10      0.27     89.86

What do you think about the patch?
CHANGES
activity.c
iostat.c
iostat.h
rd_stats.c
rd_stats.h