]> granicus.if.org Git - clang/commit
CGBuiltin.cpp: Fix abuse of ArrayRef in EmitOverflowIntrinsic().
authorNAKAMURA Takumi <geek4civic@gmail.com>
Sun, 13 Jan 2013 11:26:44 +0000 (11:26 +0000)
committerNAKAMURA Takumi <geek4civic@gmail.com>
Sun, 13 Jan 2013 11:26:44 +0000 (11:26 +0000)
commit563fb903fab15972e2d9c66b0ae046a94be86a71
tree061c418796450d93d1bad8d6cce2444e384c0f8d
parent4e9008ac62b4c403c5c30724953664dcbb03d02e
CGBuiltin.cpp: Fix abuse of ArrayRef in EmitOverflowIntrinsic().

In ArrayRef<T>(X), X should not be temporary value. It could be rewritten more redundantly;

  llvm::Type *XTy = X->getType();
  ArrayRef<llvm::Type *> Ty(XTy);
  llvm::Value *Callee = CGF.CGM.getIntrinsic(IntrinsicID, Ty);

Since it is safe if both XTy and Ty are temporary value in one statement, it could be shorten;

  llvm::Value *Callee = CGF.CGM.getIntrinsic(IntrinsicID, ArrayRef<llvm::Type*>(X->getType()));

ArrayRef<T> has an implicit constructor to create uni-entry of T;

  llvm::Value *Callee = CGF.CGM.getIntrinsic(IntrinsicID, X->getType());

MSVC-generated clang.exe crashed.

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@172352 91177308-0d34-0410-b5e6-96231b3b80d8
lib/CodeGen/CGBuiltin.cpp