]> granicus.if.org Git - postgresql/commit
adminpack: Revoke EXECUTE on pg_logfile_rotate()
authorStephen Frost <sfrost@snowman.net>
Mon, 7 May 2018 14:10:45 +0000 (10:10 -0400)
committerStephen Frost <sfrost@snowman.net>
Mon, 7 May 2018 14:10:45 +0000 (10:10 -0400)
commit53b79ab4fe722b1030b7e9a1580b283fca956e30
tree48069959c94ae1eb3cc7be38f181391da0a0d17f
parent5c4049472db9088e9325e94fcac6d994ea3f0089
adminpack: Revoke EXECUTE on pg_logfile_rotate()

In 9.6, we moved a number of functions over to using the GRANT system to
control access instead of having hard-coded superuser checks.

As it turns out, adminpack was creating another function in the catalog
for one of those backend functions where the superuser check was
removed, specifically pg_rotate_logfile(), but it didn't get the memo
about having to REVOKE EXECUTE on the alternative-name function
(pg_logfile_rotate()), meaning that in any installations with adminpack
on 9.6 and higher, any user is able to run the pg_logfile_rotate()
function, which then calls pg_rotate_logfile() and rotates the logfile.

Fix by adding a new version of adminpack (1.1) which handles the REVOKE.
As this function should have only been available to the superuser, this
is a security issue, albeit a minor one.

Security: CVE-2018-1115
contrib/adminpack/Makefile
contrib/adminpack/adminpack--1.0--1.1.sql [new file with mode: 0644]
contrib/adminpack/adminpack--1.1.sql [new file with mode: 0644]
contrib/adminpack/adminpack.control