]> granicus.if.org Git - postgresql/commit
Fix incorrect logic for excluding range constructor functions in pg_dump.
authorTom Lane <tgl@sss.pgh.pa.us>
Fri, 23 Sep 2016 17:49:27 +0000 (13:49 -0400)
committerTom Lane <tgl@sss.pgh.pa.us>
Fri, 23 Sep 2016 17:49:27 +0000 (13:49 -0400)
commit53b29d986468a9eac6fcc8fddfce4da209b4f6a2
tree7c0fd5c75b836a2b4558ec5aca019f2a8a71ea11
parent8552f9b903a099d82763460cb7ca28715d0ad2bb
Fix incorrect logic for excluding range constructor functions in pg_dump.

Faulty AND/OR nesting in the WHERE clause of getFuncs' SQL query led to
dumping range constructor functions if they are part of an extension
and we're in binary-upgrade mode.  Actually, we don't want to dump them
separately even then, since CREATE TYPE AS RANGE will create the range's
constructor functions regardless.  Per report from Andrew Dunstan.

It looks like this mistake was introduced by me, in commit b985d4877, in
perhaps-overzealous refactoring to reduce code duplication.  I'm suitably
embarrassed.

Report: <34854939-02d7-f591-5677-ce2994104599@dunslane.net>
src/bin/pg_dump/pg_dump.c