]> granicus.if.org Git - postgresql/commit
Fix planning of parameterized appendrel paths with expensive join quals.
authorTom Lane <tgl@sss.pgh.pa.us>
Mon, 8 Jul 2013 02:37:24 +0000 (22:37 -0400)
committerTom Lane <tgl@sss.pgh.pa.us>
Mon, 8 Jul 2013 02:37:24 +0000 (22:37 -0400)
commit5372275b4b5fc183c6c6dd4517cfd74d5b641446
tree4e4927c2dc340e6206364bfc62b71eab93d913f0
parent9b2543a4018c7f746bdb8d379c4ebc89c7d5f831
Fix planning of parameterized appendrel paths with expensive join quals.

The code in set_append_rel_pathlist() for building parameterized paths
for append relations (inheritance and UNION ALL combinations) supposed
that the cheapest regular path for a child relation would still be cheapest
when reparameterized.  Which might not be the case, particularly if the
added join conditions are expensive to compute, as in a recent example from
Jeff Janes.  Fix it to compare child path costs *after* reparameterizing.
We can short-circuit that if the cheapest pre-existing path is already
parameterized correctly, which seems likely to be true often enough to be
worth checking for.

Back-patch to 9.2 where parameterized paths were introduced.
src/backend/optimizer/path/allpaths.c
src/test/regress/expected/union.out
src/test/regress/sql/union.sql