]> granicus.if.org Git - postgresql/commit
Revert patch for taking fewer snapshots.
authorTom Lane <tgl@sss.pgh.pa.us>
Mon, 26 Nov 2012 20:55:43 +0000 (15:55 -0500)
committerTom Lane <tgl@sss.pgh.pa.us>
Mon, 26 Nov 2012 20:55:43 +0000 (15:55 -0500)
commit532994299e2ff208a58376134fab75f5ae471e41
tree640a22d6172d9dbdccf88ecc1195c6a23a3b0a8c
parentd3237e04ca380d6c08f6133fde97a9d956e3161a
Revert patch for taking fewer snapshots.

This reverts commit d573e239f03506920938bf0be56c868d9c3416da, "Take fewer
snapshots".  While that seemed like a good idea at the time, it caused
execution to use a snapshot that had been acquired before locking any of
the tables mentioned in the query.  This created user-visible anomalies
that were not present in any prior release of Postgres, as reported by
Tomas Vondra.  While this whole area could do with a redesign (since there
are related cases that have anomalies anyway), it doesn't seem likely that
any future patch would be reasonably back-patchable; and we don't want 9.2
to exhibit a behavior that's subtly unlike either past or future releases.
Hence, revert to prior code while we rethink the problem.
doc/src/sgml/release-9.2.sgml
src/backend/commands/portalcmds.c
src/backend/commands/prepare.c
src/backend/executor/spi.c
src/backend/tcop/postgres.c
src/backend/tcop/pquery.c
src/include/tcop/pquery.h